refactor(ios): move rejectPromiseWithMessage helper into RNMLKit core#260
Merged
Conversation
The rejectPromiseWithMessage Swift helper was duplicated verbatim in the face-detection, object-detection, and image-labeling modules. Move it to RNMLKitCore as a public function so it can be shared across modules (including the upcoming barcode scanning module) instead of being copied into each one. Closes #254
🦋 Changeset detectedLatest commit: 309434a The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #254.
The
rejectPromiseWithMessageSwift helper was duplicated verbatim in three modules (face-detection, object-detection, and image-labeling). This moves it intoRNMLKitCoreas apublicfunction so it can be shared across modules — including the upcoming barcode scanning work mentioned in the issue — rather than being copied into each one.Changes
modules/react-native-mlkit-core/ios/RNMLKitPromise.swiftdefining apublic func rejectPromiseWithMessage(promise:message:domain:).react-native-mlkit-face-detectionreact-native-mlkit-object-detectionreact-native-mlkit-image-labelingimport RNMLKitCoreto the object-detection and image-labeling module files (face-detection already imported it). All three modules already declareRNMLKitCoreas a podspec dependency.coreminor — new public API; the three consumers patch).Notes
The function body is unchanged from the original, so behavior is identical. This is an iOS-only change; nothing was needed on the Kotlin/Android side.
https://claude.ai/code/session_01SjeGje7R2MyoYDFjEVR3qt
Generated by Claude Code